Skip to content

Conversation

@prady0t
Copy link
Collaborator

@prady0t prady0t commented Jul 12, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

Adding support for the unstack function.

Signed-off-by: Pradyot Ranjan <[email protected]>
axis = ndim + axis
new_order = (axis,) + tuple(i for i in range(ndim) if i != axis)
x = x.transpose(new_order)
return (*x,)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice short-cut!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was so happy to find it πŸ˜„

@hameerabbasi hameerabbasi enabled auto-merge (squash) July 12, 2025 20:51
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 12, 2025

CodSpeed Performance Report

Merging #883 will degrade performances by 39.39%

Comparing prady0t:unstack-function (3738bb5) with main (92842c2)

Summary

⚑ 1 improvements
❌ 1 regressions
βœ… 338 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚑ test_index_fancy[side=100-rank=1-format='coo'] 891.1 ¡s 711.7 ¡s +25.2%
❌ test_index_slice[side=100-rank=2-format='gcxs'] 1.9 ms 3.1 ms -39.39%

@hameerabbasi hameerabbasi disabled auto-merge July 14, 2025 08:44
@hameerabbasi hameerabbasi merged commit af83b26 into pydata:main Jul 14, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants